[ 
https://issues.apache.org/jira/browse/WICKET-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703813#action_12703813
 ] 

Mike Comb commented on WICKET-2235:
-----------------------------------

That is correct.  The "return false" is what is causing the problem.  The 
onclick was previously there at least as far back as 1.3 and was not 
problematic on it's own, at least not in our application.

> Image tags using full paths are broken when wrapped in an a tag that uses 
> wicket:link
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-2235
>                 URL: https://issues.apache.org/jira/browse/WICKET-2235
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Safari  on OS X, probably others
>            Reporter: Mike Comb
>            Assignee: Igor Vaynberg
>
> HTML that looks like this:
> <wicket:link><a href="SomePage.html"><img src="/some/full/path/image.gif" 
> /></a></wicket:link>
> Will get converted to this:
> <wicket:link><a href="../SomePage"><img 
> onclick="window.location.href='/some/full/path/image.gif';return false;" 
> src="/some/full/path/image.gif"/></a></wicket:link>
> The onclick that gets added to the image is unnecessary and results in the 
> browser directing to the image rather than the intended target page when the 
> image is clicked on.  This behavior is still present in trunk as of 4/22/09.  
> A temporary workaround is to comment out the offending line in 
> ExternalLink.java that is adding the onclick event.  It's unclear to me what 
> the purpose of that event is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to