[
https://issues.apache.org/jira/browse/WICKET-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2293.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC5
Assignee: Igor Vaynberg
> Form loadPersistentFormComponentValues condition fix
> ----------------------------------------------------
>
> Key: WICKET-2293
> URL: https://issues.apache.org/jira/browse/WICKET-2293
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC4
> Reporter: Jan Sýkora
> Assignee: Igor Vaynberg
> Fix For: 1.4-RC5
>
>
> upon loading form persistent data each component is checked (Form.java:818)
> 1. if it is visible in hierarchy
> 2. if it wants have value persisted
> in my opinion the condition should be checked in reverse order - eg. first 2
> then 1
> reasons:
> a. check 2 is much faster and as FLAG_PERSISTENT is not set by default
> b. in case parent component is not visible, the isVisibleInHierarchy on
> component won't be unnecessarily called
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
