[
https://issues.apache.org/jira/browse/WICKET-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Soneira updated WICKET-2343:
-----------------------------------
Description:
The popup settings are ONLY considered for the resulting JavaScript code when
you use the setter setPopupSettings (which is final).
The method getPopupSettings is NOT final but it has no effect - internally Link
always uses the private field - not the getter.
Something like the following code works fine - but is not really clear /
intuitive:
public class TestLink extends Link {
public TestLink(String id) {
super(id);
setPopupSettings(getPopupSettings());
}
public PopupSettings getPopupSettings() {
return new PopupSettings(PopupSettings.RESIZABLE).setWindowName("test");
}
}
I don't know which is the prefered way of Wicket core developers but I can
think of two ways to improve on this:
- Make getPopupSettings final (less work)
- Use getPopupSettings() within Link instead of the field
was:
The popup settings are ONLY considered for the resulting JavaScript code when
you use the setter setPopupSettings (which is final).
The method getPopupSettings is NOT final but is has no effect - internally Link
always uses the private field - not the getter.
Something like the following code works fine - but is not really clear /
intuitive:
public class TestLink extends Link {
public TestLink(String id) {
super(id);
setPopupSettings(getPopupSettings());
}
public PopupSettings getPopupSettings() {
return new PopupSettings(PopupSettings.RESIZABLE).setWindowName("test");
}
}
I don't know which is the prefered way of Wicket core developers but I can
think of two ways to improve on this:
- Make getPopupSettings final (less work)
- Use getPopupSettings() within Link instead of the field
> Link: PopupSettings - overriding getPopupSettings has no effect
> ---------------------------------------------------------------
>
> Key: WICKET-2343
> URL: https://issues.apache.org/jira/browse/WICKET-2343
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-RC5
> Reporter: Daniel Soneira
> Priority: Minor
> Fix For: 1.4-RC6
>
>
> The popup settings are ONLY considered for the resulting JavaScript code when
> you use the setter setPopupSettings (which is final).
> The method getPopupSettings is NOT final but it has no effect - internally
> Link always uses the private field - not the getter.
> Something like the following code works fine - but is not really clear /
> intuitive:
> public class TestLink extends Link {
> public TestLink(String id) {
> super(id);
> setPopupSettings(getPopupSettings());
> }
> public PopupSettings getPopupSettings() {
> return new
> PopupSettings(PopupSettings.RESIZABLE).setWindowName("test");
> }
> }
> I don't know which is the prefered way of Wicket core developers but I can
> think of two ways to improve on this:
> - Make getPopupSettings final (less work)
> - Use getPopupSettings() within Link instead of the field
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
