RequestCycle urlFor ignores existing parameters when appending provided params
------------------------------------------------------------------------------

                 Key: WICKET-2434
                 URL: https://issues.apache.org/jira/browse/WICKET-2434
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.0
         Environment: macosx 10.5.7, wicket 1.4.0
            Reporter: Vytautas Civilis


Link with listener and non empty parameters, built in the following fashion: 
getRequestCycle().urlFor(this, ILinkListener.INTERFACE, parameters) isn't 
formed correctly.

at RequestCycle 947:
AppendingStringBuffer buff = new AppendingStringBuffer(url);
WebRequestEncoder encoder = new WebRequestEncoder(buff);

This WebRequestEncoder doesn't check, if the parameters are already present in 
the url provided.

In my case, the url from CharSequence url = encodeUrlFor(target); is already 
similar to:  
?wicket:interface=:2:admin:container:tabbedPanel:panel:apartments:0:apartmentAddressEditLink:1:ILinkListener::

What WebRequestEncoder does when appending parameters provided explicitly - it 
simply appends "?" mark and then the parameters list.

So resulting url is incorrect and doesn't work:
?wicket:interface=:2:admin:container:tabbedPanel:panel:apartments:0:apartmentAddressEditLink:1:ILinkListener::?height=300&width=300

(notice leading ?height=300&width=300).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to