[ 
https://issues.apache.org/jira/browse/WICKET-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762007#action_12762007
 ] 

Leszek Gawron commented on WICKET-2436:
---------------------------------------

Current implementation is even more broken:

<thead wicket:id="topToolbars">
        <wicket:container wicket:id="toolbar"></wicket:container>
</thead>
<thead wicket:id="bottomToolbars">
        <wicket:container wicket:id="toolbar"></wicket:container>
</thead>
<tbody>
        <tr wicket:id="rows">
                <td wicket:id="cells">
                        <span wicket:id="cell">[cell]</span>
                </td>
        </tr>
</tbody>

This causes ALL toolbars to be shown on top. 

The proper order is restored with:

<thead wicket:id="topToolbars">
        <wicket:container wicket:id="toolbar"></wicket:container>
</thead>
<tbody>
        <tr wicket:id="rows">
                <td wicket:id="cells">
                        <span wicket:id="cell">[cell]</span>
                </td>
        </tr>
</tbody>
<thead wicket:id="bottomToolbars">
        <wicket:container wicket:id="toolbar"></wicket:container>
</thead>

I have no idea if this would properly validate with XHTML.


> invalid DataTable markup breaks table layout
> --------------------------------------------
>
>                 Key: WICKET-2436
>                 URL: https://issues.apache.org/jira/browse/WICKET-2436
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.4.1
>            Reporter: Daniel Peters
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.4.2, 1.5-M1
>
>
> I upgraded from 1.4.0 from 1.4.1 and noticed that my table toolbars are 
> rendered diffrently. Some bottom-toolbars are suddenly at the top.
> The reason for that is the changed markup in 1.4.1.
> Every Toolbar has its own <thead></thead> or <tfoot></tfoot> now! 
> Normaly (like in <= 1.4.0) it should be one <thead> which includes all the 
> <tr>s.
> Firefox only renders one tfoot at the bottom of the table and puts the rest 
> at the top.
> To reproduce add more than one bottom-toolbar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to