[
https://issues.apache.org/jira/browse/WICKET-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769409#action_12769409
]
Juergen Donnerstag commented on WICKET-2531:
--------------------------------------------
I don't think the provide patch is good enough
String option = getLocalizer().getStringIgnoreSettings(getNullValidKey(),
this,null, null);
if (Strings.isEmpty(option))
{
option = getLocalizer().getString("nullValid", this, "");
}
getNullValidKey() can be redefined but if not found, "nullValid" without id is
still used.
> Open DropDownChoice null value internationalization key
> -------------------------------------------------------
>
> Key: WICKET-2531
> URL: https://issues.apache.org/jira/browse/WICKET-2531
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.1
> Reporter: Guillaume Mary
> Priority: Trivial
> Attachments: AbstractSingleSelectChoice.java
>
>
> DropDownChoice null value internationalization key is hardcoded in
> AbstractSingleSelectChoice.getDefaultChoice(Object);
> The same happen for nullValid.
> I suggest to externalize the building of these keys in 2 other methods.
> See discussion
> http://www.nabble.com/DropDownChoice-and-null-value-internationalization-key-td25924643.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
