[
https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770124#action_12770124
]
James Carman commented on WICKET-2393:
--------------------------------------
Is the consensus that the password field should never trim? I don't know about
that. What if you copy/paste a password from your email and you accidentally
include a space at the end or something? I have never used a leading/trailing
space on my passwords (or a space in the middle for that matter). Is this a
common practice? I like Juergen's suggestion of having the user override
shouldTripInput() if they want a non-trimming password field.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the
> begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the
> PasswordTextField class. I provided a patch (attached to this issue), please
> indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
