[ 
https://issues.apache.org/jira/browse/WICKET-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772189#action_12772189
 ] 

Igor Vaynberg commented on WICKET-2555:
---------------------------------------

this is basically neatpicking and i am against doing this in 1.4.x, but fine in 
1.5.x.

uncontended locks are very cheap in java 5 and even cheaper in java 6. if you 
showed me a profiler snapshot where this showed up as a hotspot i would be all 
over it, but that would be very hard to create i think.


> Replace implementations of StringBuffer with StringBuilder
> ----------------------------------------------------------
>
>                 Key: WICKET-2555
>                 URL: https://issues.apache.org/jira/browse/WICKET-2555
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.3
>         Environment: N/A
>            Reporter: James Perry
>            Priority: Minor
>             Fix For: 1.5-M1
>
>         Attachments: stringbuilder.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Given that 1.4.x depends on the 1.5 JDK, we might as well take advantage of 
> the performance gains of replacing the StringBuffer class with StringBuilder.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to