[ 
https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788108#action_12788108
 ] 

Neil Curzon commented on WICKET-2569:
-------------------------------------

The current behavior IS that the child magically overrides the parent. This is 
exactly what my patch fixes. After the patch, the ?xml header comes from the 
parent. In 1.4.3, the ?xml header comes from the child.

You can verify this by using the attached quickstart, and moving the ?xml 
header from the parent, SuperPage.html, to the child, SuperPageWithMarkup.html. 
With 1.4.3, the final output has the ?xml header, the one from the child. With 
1.4-SNAPSHOT after the patch, the ?xml header is in the final output ONLY if 
it's in the parent.

> Inheritance layout excludes XML header from output
> --------------------------------------------------
>
>                 Key: WICKET-2569
>                 URL: https://issues.apache.org/jira/browse/WICKET-2569
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.3.7, 1.4.3
>            Reporter: Neil Curzon
>            Assignee: Juergen Donnerstag
>         Attachments: wicket-2569.patch, wicket-2569.tgz
>
>
> When using inheritance layout, if the superclass (Layout class) has an ?xml 
> header at the top, it's excluded from the rendering of subclasses, if they 
> have an associated html file. If the subclass has no .html file associated 
> with it, the ?xml header is preserved in the rendering output.
> To reproduce: Create a SuperPage class extending WebPage. At the top of 
> SuperPage.html, put "<?xml version="1.0" encoding="utf-8"?>" . Create two 
> subclasses of SuperPage, one with an HTML file and one without. View the sub 
> pages. Notice when the one with an HTML file is rendered, the xml header is 
> excluded.
> Expected: The ?xml header should always be preserved in the rendered output 
> as it's vital to the layout.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to