[
https://issues.apache.org/jira/browse/WICKET-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806854#action_12806854
]
Juergen Donnerstag commented on WICKET-2693:
--------------------------------------------
you are right that different strategies per component make no sense, but lets
separate the topics a bit:
- currently the execution logic is burried insight and almost copied & pasted
in two places. I extracted that logic into a separate class (header render
strategy) which implements a simple interface (one method). IMO in any case a
good idea since it improves code quality
- Than I extended IAppliationSettings to be able to change the implementation
(made it pluggable on application level). If we for sure know there is no
reason for any app to provide a derivation of that implementation, than we
don't need that or we make it final until someone has a proper use case
The reason why you thought about changing the execution order was probably
because you faced that problem. But can we be sure that the new order will not
have different but equally valid problems? Wouldn't it be nice if a user had
better control over the placement of his header contribution. One option could
be something like a scope or prio per contribution which is considered by the
header render strategy. If that is too much but we still want some flexibility,
than a modified (pluggable) header render strategy would do as well. E.g.
render the header of component XYZ always last. That would be simple to
implement for any user.
> improve css/js contributions
> ----------------------------
>
> Key: WICKET-2693
> URL: https://issues.apache.org/jira/browse/WICKET-2693
> Project: Wicket
> Issue Type: Improvement
> Reporter: Igor Vaynberg
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
>
> currently the order of css contributions is
> page (1st)->container(2nd)->component(3rd)
> we should inverse this order and allow deepest nested components to
> contribute first, this way an outer container's contributions will appear
> below allowing the container to override the css/javascript
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
