[
https://issues.apache.org/jira/browse/WICKET-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834014#action_12834014
]
Paul Giblock commented on WICKET-2747:
--------------------------------------
Actually, things are more complex. It cannot be based on AbstractLink without
some hefty refactoring. The PagingNavigation*Link classes need to be able to
trap when the link is clicked - AbstractLink does not provide this hook. And,
unfortunately, SubmitLink has a onSubmit method while Link<T> has a onClick
link. What would have to happen is some sort of interface like IClickable be
shared between the two classes - or maybe SubmitLink can inherit Link<>?
Otherwise, the only real alternative is to make an entirely separate hierarchy
of: PagingNavigationSubmitLink, PagingNavigationIncrementSubmitLink,
SubmittingPagingNavigator, AjaxSubmittingPagingNavigation,
AjaxSubmittingPagingNavigationBehavior, AjaxPagingNavigationSubmitLink,
AjaxPagingNavigationIncrementSubmitLink, and finally,
AjaxSubmittingPagingNavigator
Quite a few classes to reproduce just to have a navigator within a form.. I
still don't have a working version, and I'm leaving the office. I'll report
back tomorrow.
> AjaxPagingNavigator Link factories should return AbstractLink
> -------------------------------------------------------------
>
> Key: WICKET-2747
> URL: https://issues.apache.org/jira/browse/WICKET-2747
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.5
> Environment: CentOS 5.0, Sun Glassfish v2.1, Wicket 1.4.x.
> Reporter: Paul Giblock
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AjaxPagingNavigator doesn't submit forms. The mailinglists instruct the user
> to override the Link factory classes in order to return SubmitLinks.
> However, both SubmitLink and AjaxSubmitLink do not inherit from Link. It is
> my opinion that AjaxPagingNavigator.new*Link() functions should return
> AbstractLink.
> I am currently forced to fork the majority of AjaxPagingNavigator inorder to
> create a "Sub"class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.