Author: ivaynberg
Date: Tue Feb 16 19:32:58 2010
New Revision: 910656

URL: http://svn.apache.org/viewvc?rev=910656&view=rev
Log:
WICKET-2748 fix IE6 which breaks when wicket passes in "null" as a function 
reference.
Issue: WICKET-2748

Modified:
    
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java

Modified: 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java?rev=910656&r1=910655&r2=910656&view=diff
==============================================================================
--- 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
 (original)
+++ 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
 Tue Feb 16 19:32:58 2010
@@ -197,23 +197,10 @@
                buff.append("var 
").append(IAjaxCallDecorator.WICKET_CALL_RESULT_VAR).append("=");
                buff.append(partialCall);
 
-               if (success.length() == 0)
-               {
-                       buff.append(",null");
-               }
-               else
-               {
-                       
buff.append(",function(){").append(success).append("}.bind(this)");
-               }
-
-               if (failure.length() == 0)
-               {
-                       buff.append(",null");
-               }
-               else
-               {
-                       buff.append(",function() { 
").append(failure).append("}.bind(this)");
-               }
+               // IE 6 breaks if we pass in null for function reference, so we 
pass in an empty function
+               // instead
+               buff.append(",function() { 
").append(success).append("}.bind(this)");
+               buff.append(",function() { 
").append(failure).append("}.bind(this)");
 
                if (precondition != null)
                {


Reply via email to