[
https://issues.apache.org/jira/browse/WICKET-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov updated WICKET-2788:
------------------------------------
Attachment: wicket-2788-MarkupContainer.patch
wicket-2788.patch
wicket-2788.patch finishes the API change and makes all tests pass.
There are two notes:
1) I removed the nested Traversal (childTraversal) object in MarkupContainer.
Please review if this is correct! Without this change some tests failed (the
change may be seen in wicket-2788-MarkupContainer.patch).
2) in FormComponent, line 987 the return type should be j.l.Boolean but for
some reason command line Maven (both 2.2.1 and 3.0-alpha7) fails to build it.
Eclipse (with m2eclipse) builds it successfully. I changed it to j.l.Object and
now it builds ok everywhere. Please take a look.
> Make visitor api cleaner
> ------------------------
>
> Key: WICKET-2788
> URL: https://issues.apache.org/jira/browse/WICKET-2788
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.7
> Reporter: Igor Vaynberg
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M1
>
> Attachments: wicket-2788-MarkupContainer.patch, wicket-2788.patch,
> wicket-visitors.patch
>
>
> clean up the visitor api so we are not returning magic objects like
> IVisitor.CONTINUE and IVisitor.CONTINUE_BUT_DO_NOT_GO_DEEPER. it should also
> be possible to return null from the visitors, currently reserved for
> IVisitor.CONTINUE
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
