[ 
https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861020#action_12861020
 ] 

James Carman commented on WICKET-2620:
--------------------------------------

I believe the fix for this issue has caused a regression in my code.  I have a 
custom subclass of DataTable with markup:

<wicket:panel>

    <span wicket:id="topToolbars">
      <span wicket:id="toolbar"></span>
    </span>


        <tr wicket:id="rows">
            <td wicket:id="cells">
                <span wicket:id="cell">[cell]</span>
            </td>
        </tr>

    <span wicket:id="bottomToolbars">
      <span wicket:id="toolbar"></span>
    </span>

</wicket:panel>

In 1.4.6, my page fails to render.  In 1.4.5, it works fine.

> DataTable generates two <thead wicket:id="topToolbars">
> -------------------------------------------------------
>
>                 Key: WICKET-2620
>                 URL: https://issues.apache.org/jira/browse/WICKET-2620
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.4.3
>            Reporter: Stefan Schueffler
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.4.6, 1.5-M1
>
>
> The tables generated by DataTable component in the current version of Wicket 
> (1.4.3) do not contain <thead> in the output HTML.
> It was working correctly in wicket 1.4.0 but there were some changes to fix 
> other issues - see WICKET-2436
> To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable 
> example:
> http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> If you check the HTML source you will see it does not contain thead tag:
> {html}
> <table class="dataview" cellspacing="0">
>       <tr class="navigation">
> {html}
> When you look at 
> http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
> it shows:
> {html}
> <table class="dataview" cellspacing="0">
> <thead>
>       <tr class="navigation">
> {html}
> Must be a previous version? :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to