[
https://issues.apache.org/jira/browse/WICKET-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2871:
---------------------------------
Attachment: wicket-2871.patch
You are totally right, my bad... That shows that working on holidays is never a
good plan :-)
For the record I uploaded a new patch file with the right changes, I also
noticed that a few methods were missing in Session. It still breaks the tests,
though it shows my original intension.
PS:
The fact that the methods in Session are not compatible for Component strikes
me as odd because Component now completely circumvents the API and gets an
unmodifiable list of messages which it adds a new message to. (??)
> Component registers feedback messages badly
> -------------------------------------------
>
> Key: WICKET-2871
> URL: https://issues.apache.org/jira/browse/WICKET-2871
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7,
> 1.4.8
> Environment: Windows 7
> Wicket 1.4.7
> Reporter: Hielke Hoeve
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Attachments: Session.patch, wicket-2871.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Component registers feedback messages by adding them to the FeedbackMessages
> class directly while there are special functions in Session to do this.
> Component should call Session.get().error(message) in the following example.
> I have attached a patch file which fixes this.
> Example:
> Component.class
> public final void error(final Serializable message)
> {
> Session.get().getFeedbackMessages().error(this, message);
> Session.get().dirty();
> }
> Session.class:
> public final void error(final String message)
> {
> addFeedbackMessage(message, FeedbackMessage.ERROR);
> }
> private void addFeedbackMessage(String message, int level)
> {
> getFeedbackMessages().add(null, message, level);
> dirty();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
