[ 
https://issues.apache.org/jira/browse/WICKET-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897831#action_12897831
 ] 

Florian Wunderlich commented on WICKET-2979:
--------------------------------------------

Yes, I believe that handling it in a method like logRuntimeException would be 
correct.

The Throwable would be logged as usual, and cannot go unnoticed in a Servlet 
container logfile.

And the behavior when an unhandled exception is encountered would be 
well-defined and not depend on the Servlet container.

Last not least, the application would actually have a chance to handle such an 
exception - otherwise, I believe there is no way an application based on an 
unpachted Wicket library can handle these exceptions.

Because the same error page should always be displayed to the user, regardless 
of what Throwable was thrown, IRequestCycleProcessor.respond should also be 
switched to Throwable.

> Handle Throwable instead of RuntimeException in RequestCycle.step()
> -------------------------------------------------------------------
>
>                 Key: WICKET-2979
>                 URL: https://issues.apache.org/jira/browse/WICKET-2979
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Florian Wunderlich
>            Assignee: Martin Grigorov
>
> RequestCycle.java:1346 catches only RuntimeException, thus AssertionError and 
> similar are not caught. In case of an AJAX request, the container will 
> respond with an error page which the user will never see.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to