[ 
https://issues.apache.org/jira/browse/WICKET-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900978#action_12900978
 ] 

Peter Ertl commented on WICKET-3004:
------------------------------------

Indeed, your patch is a lot cleaner. Sometimes you can't see the forest for the 
trees :-)

> Using RedirectPolicy.NEVER_REDIRECT when redirecting to a page will break URLs
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-3004
>                 URL: https://issues.apache.org/jira/browse/WICKET-3004
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>            Priority: Critical
>             Fix For: 1.5-M2
>
>         Attachments: broken-url-when-never-redirecting.patch
>
>
> When using RedirectPolicy.NEVER_REDIRECT the WebPageRenderer uses the URL of 
> the __target__ page instead of the current URL. This is wrong as the target 
> page URL will never be visible in the address bar of the browser as no 
> redirect will happen.
> In consequence all references to the page (scripts, images, etc) are 
> potentially broken, at least when the source and target url have different 
> segment sizes. In this case the number of '../' for creating relative URL's 
> will be wrong and the links are broken.
> patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to