Google chrome vs. userAgent problem
-----------------------------------

                 Key: WICKET-3096
                 URL: https://issues.apache.org/jira/browse/WICKET-3096
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.12
            Reporter: Jan Loose


I have installed [Google 
ChromeFrame|http://code.google.com/chrome/chromeframe/], but this IE extension 
is disabled, but on this doesn't matter and there is still modified userAgent 
with 'chromeframe' text. The useragent is modified even though it is 
[uninstalled|http://groups.google.com/group/google-chrome-frame/browse_thread/thread/dbaffaa30af23b91?pli=1].

{code}mozilla/4.0 (compatible; msie 8.0; windows nt 5.1; trident/4.0; 
chromeframe; infopath.2; .net clr 2.0.50727; .net clr 3.0.04506.648; .net clr 
3.5.21022; .net clr 3.0.4506.2152; .net clr 3.5.30729){code}

This is problem because in new version of wicket, there is test for chrome 
browsers and it looks like:

{code}boolean browserChrome = userAgent.indexOf("chrome") != -1;{code}

This causes the IE is not recognized correctly and some thinks don't work well.

The solution should be easy:

{code}boolean browserChrome = userAgent.indexOf("chrome") != -1 && 
userAgent.indexOf("chromeframe") == -1;{code}
or
{code}boolean browserChrome = userAgent.indexOf("chrome/") != -1;{code}

But I'm not sure how chromeframe work if the chromeframe is activated (if there 
is still the same userAgent or there is userAgent like normal Chrome).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to