Author: mgrigorov
Date: Sun Nov 14 10:35:39 2010
New Revision: 1034971

URL: http://svn.apache.org/viewvc?rev=1034971&view=rev
Log:
WICKET-3138 Wicket 1.5 and GAE support

PageNumberEvictionStrategy allows only positive number of pages

Modified:
    
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategy.java
    
wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategyTest.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategy.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategy.java?rev=1034971&r1=1034970&r2=1034971&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategy.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategy.java
 Sun Nov 14 10:35:39 2010
@@ -34,6 +34,11 @@ public class PageNumberEvictionStrategy 
         */
        public PageNumberEvictionStrategy(int pagesNumber)
        {
+               if (pagesNumber < 1)
+               {
+                       throw new IllegalArgumentException("'pagesNumber' must 
be greater than 0.");
+               }
+
                this.pagesNumber = pagesNumber;
        }
 

Modified: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategyTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategyTest.java?rev=1034971&r1=1034970&r2=1034971&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategyTest.java
 (original)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/memory/PageNumberEvictionStrategyTest.java
 Sun Nov 14 10:35:39 2010
@@ -51,4 +51,13 @@ public class PageNumberEvictionStrategyT
                assertNotNull(pageTable.getPage(PAGE2.length));
                assertNull(pageTable.getPage(PAGE1.length));
        }
+
+       /**
+        * The number of pages must be at least '1'
+        */
+       @Test(expected = IllegalArgumentException.class)
+       public void greaterThanZero()
+       {
+               new PageNumberEvictionStrategy(0);
+       }
 }


Reply via email to