IResourceSettings getStringResourceLoaders doc says unmodifiable but 
ApplicationSettingsTest clears
---------------------------------------------------------------------------------------------------

                 Key: WICKET-3188
                 URL: https://issues.apache.org/jira/browse/WICKET-3188
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5-M3
         Environment: All
            Reporter: Richard Emberson
            Priority: Trivial


The javadoc for IResourceSettings getStringResourceLoaders method says:
 @return an unmodifiable list of all available string resource loaders
But the test, ApplicationSettingsTest testOverrideStringResourceLoaderSetup
calls
settings.getStringResourceLoaders.clear

My vote is to add the following method to IResourceSettings and its 
implementations:

  /**
   * Clears the resource loaders
   * <p>
   * Note: This is used for testing
   */
  def clearStringResourceLoaders: Unit 

Returning immutable data structures is a good-thing, but tests have to have a 
back door.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to