Author: mgrigorov
Date: Thu Dec  2 16:58:58 2010
New Revision: 1041454

URL: http://svn.apache.org/viewvc?rev=1041454&view=rev
Log:
WICKET-3212 WicketTester can't create new sessions

Detach the session on RequestCycle#onDetach(), don't destroy it.
BaseWicketTester#createNewSession() always creates a new Session

Modified:
    wicket/trunk/wicket/src/main/java/org/apache/wicket/Session.java
    
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Session.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Session.java?rev=1041454&r1=1041453&r2=1041454&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Session.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Session.java Thu Dec  2 
16:58:58 2010
@@ -446,7 +446,7 @@ public abstract class Session implements
                                @Override
                                public void onDetach(final RequestCycle cycle)
                                {
-                                       destroy();
+                                       detach();
                                }
                        });
                }

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java?rev=1041454&r1=1041453&r2=1041454&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
 Thu Dec  2 16:58:58 2010
@@ -353,8 +353,9 @@ public class BaseWicketTester
         */
        private void createNewSession()
        {
+               ThreadContext.setSession(null);
+               // the following will create a new session and put it in the 
thread context
                session = Session.get();
-               ThreadContext.setSession(session);
        }
 
        /**


Reply via email to