[ 
https://issues.apache.org/jira/browse/WICKET-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juergen Donnerstag resolved WICKET-3246.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

> AnnotProxyFieldValueFactory getBeanNameOfClass move if-test outside of 
> while-loop
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-3246
>                 URL: https://issues.apache.org/jira/browse/WICKET-3246
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-spring
>    Affects Versions: 1.5-M3
>         Environment: all
>            Reporter: Richard Emberson
>            Priority: Trivial
>             Fix For: 1.5-M4
>
>
> Same issue as https://issues.apache.org/jira/browse/WICKET-3245
> Move the if-test outside of while-loop
> from:
>     Iterator<String> it = names.iterator();
>     while (it.hasNext())
>     {
>       final String possibility = it.next();
>       if (ctx instanceof AbstractApplicationContext)
>       {
>         BeanDefinition beanDef = 
> getBeanDefinition(((AbstractApplicationContext)ctx)
>             .getBeanFactory(), possibility);
>         if (BeanFactoryUtils.isFactoryDereference(possibility) ||
>             possibility.startsWith("scopedTarget.") || 
> !beanDef.isAutowireCandidate())
>         {
>           it.remove();
>         }
>       }
>     }
> to:
>     if (ctx instanceof AbstractApplicationContext)
>     {
>       Iterator<String> it = names.iterator();
>       while (it.hasNext())
>       {
>         final String possibility = it.next();
>         BeanDefinition beanDef = 
> getBeanDefinition(((AbstractApplicationContext)ctx)
>             .getBeanFactory(), possibility);
>         if (BeanFactoryUtils.isFactoryDereference(possibility) ||
>             possibility.startsWith("scopedTarget.") || 
> !beanDef.isAutowireCandidate())
>         {
>           it.remove();
>         }
>       }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to