[ 
https://issues.apache.org/jira/browse/WICKET-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov updated WICKET-3126:
------------------------------------

    Fix Version/s: 1.5-M4
         Assignee:     (was: Martin Grigorov)

Set the "Fix Version" to 1.5-M4.
We need to decide whether to change the API before starting release candidates.

@Devs: please review the patch. Currently it is not possible to mount a page at 
"/".
Using Application.getHomePage() works but always creates Url like 
"/wicket/bookmarkable/com.example.MyHomePage" which is not acceptable for some 
users.

> Drop HomePageMapper in favour of MountedMapper("/", MyPage.class)
> -----------------------------------------------------------------
>
>                 Key: WICKET-3126
>                 URL: https://issues.apache.org/jira/browse/WICKET-3126
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M2.1
>            Reporter: Martin Grigorov
>             Fix For: 1.5-M4
>
>         Attachments: WICKET-3126-provider.patch, WICKET-3126.patch, 
> WICKET-3126.patch, WICKET-3126.patch
>
>
> Currently requests to '/' are handled by HomePageMapper when the request 
> comes and by BookmarkableMapper when an Url should be created (e.g. for 
> links, forms, redirects, etc.). So requesting '/' ends with URL in the 
> browser address bar like : "/wicket/bookmarkable/com.example.MyPage" 
> (generated by BookmarkableMapper).
> The final Url is a bit confusing to users.
> Here is suggestion for improvement:
> drop HomePageMapper and use MountedMapper("/", app.getHomePage()) instead. 
> This mapper will be registered after SystemMapper so it will be asked before 
> all pre-configured mappers. if the user application still wants to map 
> something else than Application#getHomePage() at "/" then it can do : add(new 
> MountedMapper("/", CustomPage.class).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to