svn commit: r1058922 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

[mgrigorov]

Author: mgrigorov
Date: Fri Jan 14 10:05:06 2011
New Revision: 1058922

URL: http://svn.apache.org/viewvc?rev=1058922&view=rev
Log:
WICKET-3331 DropDownChoice with wantOnSelectionChangedNotifications fails 
without Form
WICKET-2829 Tag attributes values are not escaped properly during writeOutput

Tag attributes are XML escaped in one place (see WICKET-2829), no need to use 
entities while constructing URLs which will be used as attribute values

Modified:
    
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java?rev=1058922&r1=1058921&r2=1058922&view=diff
==============================================================================
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 (original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 Fri Jan 14 10:05:06 2011
@@ -242,7 +242,7 @@ public class DropDownChoice<T> extends A
                        else
                        {
                                tag.put("onchange", "window.location.href='" + 
url +
-                                       (url.toString().indexOf('?') > -1 ? 
"&amp;" : "?") + getInputName() +
+                                       (url.toString().indexOf('?') > -1 ? "&" 
: "?") + getInputName() +
                                        "=' + 
this.options[this.selectedIndex].value;");
                        }
                }