[ 
https://issues.apache.org/jira/browse/WICKET-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987692#action_12987692
 ] 

todd wolff commented on WICKET-3399:
------------------------------------

sorry.  i meant deprecate the methods getHttpServletResponse and 
getHttpServletRequest rather than deprecating the class itself.  or ... remove 
them altogether, which would force us (the users) to use the new methods you're 
creating.  all other methods in these two classes are overriding methods on 
super, i.e. the only reason users would cast to ServletWebRequest or 
ServletWebResponse would be to get the container request/response.

> HttpServletResponse is No Longer Accessible via 1.5 API
> -------------------------------------------------------
>
>                 Key: WICKET-3399
>                 URL: https://issues.apache.org/jira/browse/WICKET-3399
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: todd wolff
>            Assignee: Igor Vaynberg
>             Fix For: 1.5-RC2
>
>
> After migrating from 1.4.x to 1.5 RCI, a breaking change was encountered.  I 
> used to be able to access the servlet response object via:
> getWebRequestCycle().getWebResponse().getHttpServletResponse();
> And after migrating, expected to be able to use:
> ((ServletWebResponse)getResponse()).getHttpServletResponse();
> But I get  a ClassCastException because ServletWebResponse is wrapped a 
> couple of times, i.e. by BufferedWebResponse and then again by 
> HeaderBufferingWebResponse.  And ... these wrapper classes do not provide an 
> API to access the original wrapped response, i.e. the HttpServletResponse.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to