[ 
https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996854#comment-12996854
 ] 

Pedro Santos commented on WICKET-3433:
--------------------------------------

Hi Juergen thank for the review. The idea of skip repeated markup inside the 
conditional comments has those drawbacks you pointed, we would have to skip 
only repeated not closed tags inside different conditional comments to solve 
it. I think it can be done nicely, let me come back with another path.

I didn't fixed the MarkupParserTest by closing the link tag at 
MarkupParserTest_9.html because it wasn't failing, I just reverted it here to 
maintain it testing the tolerance of non close tags, thanks for noticed and 
test cases.


> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
>                 Key: WICKET-3433
>                 URL: https://issues.apache.org/jira/browse/WICKET-3433
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Alan Shaw
>            Assignee: Juergen Donnerstag
>              Labels: HTML5, boilerplate, doctype, html, parser
>         Attachments: WICKET-3433.patch, 
> html5boilerplate.ui.wicket.parsefail-working.zip, 
> html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse 
> HTML inside IE conditional comments when they appear between the doctype 
> declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
>       <!doctype html>
>       <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
>       <!--[if IE 7 ]>    <html lang="en" class="no-js ie7"> <![endif]-->
>       <!--[if IE 8 ]>    <html lang="en" class="no-js ie8"> <![endif]-->
>       <!--[if IE 9 ]>    <html lang="en" class="no-js ie9"> <![endif]-->
>       <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js"> 
> <!--<![endif]-->
>       
> ...which causes a problem for wicket, as it thinks there are five opening 
> <html> tags on the page.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to