[
https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pedro Santos updated WICKET-3433:
---------------------------------
Attachment: WICKET-3433.patch
Hi Juergen, in the last commit you broke the HtmlHandler validation by moving
it to postProcess (bug exposed by MarkupParserTest#testErrorOnMismatchTag in
the patch). The problem is that postProcess is not invoked for all filters in
the chain since its first filter - StyleAndScriptIdentifier - is not
forwarding the call.
I understand your idea of moving the conditional comments handle code to a
filter in the chain, I think it is OK and it is why I moved it to there in my
second patch I guess.
In your last commit you also made a relatively big change in the parser by not
considering the XmlTag as a MarkupElement. I also agree with the change, and
merged it into my patch. But I ask you to hold on further changes in the parser
until we close this ticket, because it's getting hard to follow you in the
changes.
The Wicket parser is an hostile land for newcomers, I already saw a single
innocent line invoking a method in the wrong sequence break more than 500 test
cases.
The new attached patch fix this issue, the WICKET-3500, and the on described
before.
> Wicket parses HTML inside IE conditional comments
> -------------------------------------------------
>
> Key: WICKET-3433
> URL: https://issues.apache.org/jira/browse/WICKET-3433
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-M3
> Reporter: Alan Shaw
> Assignee: Juergen Donnerstag
> Labels: HTML5, boilerplate, doctype, html, parser
> Attachments: SimplePageExpectedResult_12a.html, WICKET-3433.patch,
> html5boilerplate.ui.wicket.parsefail-working.zip,
> html5boilerplate.ui.wicket.parsefail.zip, wicket-conditional-comments.patch
>
>
> I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse
> HTML inside IE conditional comments when they appear between the doctype
> declaration and the <html> tag.
> The first lines of the boilerplate html look like this:
> <!doctype html>
> <!--[if lt IE 7 ]> <html lang="en" class="no-js ie6"> <![endif]-->
> <!--[if IE 7 ]> <html lang="en" class="no-js ie7"> <![endif]-->
> <!--[if IE 8 ]> <html lang="en" class="no-js ie8"> <![endif]-->
> <!--[if IE 9 ]> <html lang="en" class="no-js ie9"> <![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--> <html lang="en" class="no-js">
> <!--<![endif]-->
>
> ...which causes a problem for wicket, as it thinks there are five opening
> <html> tags on the page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
