svn commit: r1099169 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java

[mgrigorov]

Author: mgrigorov
Date: Tue May  3 18:17:01 2011
New Revision: 1099169

URL: http://svn.apache.org/viewvc?rev=1099169&view=rev
Log:
WICKET-3636 BookmarkablePageLink :: setParameter int versions missing

Deprecate BookmarkablePageLink#setParameter() methods.
Better use #getPageParameters().set().


Modified:
    
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java?rev=1099169&r1=1099168&r2=1099169&view=diff
==============================================================================
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java
 (original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/BookmarkablePageLink.java
 Tue May  3 18:17:01 2011
@@ -61,6 +61,10 @@ public class BookmarkablePageLink<T> ext
         */
        public PageParameters getPageParameters()
        {
+               if (parameters == null)
+               {
+                       parameters = new PageParameters();
+               }
                return parameters;
        }
 
@@ -140,11 +144,7 @@ public class BookmarkablePageLink<T> ext
 
        private void setParameterImpl(String key, Object value)
        {
-               if (parameters == null)
-               {
-                       parameters = new PageParameters();
-               }
-               parameters.set(key, value);
+               getPageParameters().set(key, value);
        }
 
        /**
@@ -155,7 +155,9 @@ public class BookmarkablePageLink<T> ext
         * @param value
         *            The value
         * @return This
+        * @deprecated Use {@link #getPageParameters()}.set() instead
         */
+       @Deprecated
        public BookmarkablePageLink<T> setParameter(final String property, 
final int value)
        {
                setParameterImpl(property, Integer.toString(value));
@@ -170,7 +172,9 @@ public class BookmarkablePageLink<T> ext
         * @param value
         *            The value
         * @return This
+        * @deprecated Use {@link #getPageParameters()}.set() instead
         */
+       @Deprecated
        public BookmarkablePageLink<T> setParameter(final String property, 
final long value)
        {
                setParameterImpl(property, Long.toString(value));
@@ -185,7 +189,9 @@ public class BookmarkablePageLink<T> ext
         * @param value
         *            The value
         * @return This
+        * @deprecated Use {@link #getPageParameters()}.set() instead
         */
+       @Deprecated
        public BookmarkablePageLink<T> setParameter(final String property, 
final String value)
        {
                setParameterImpl(property, value);