[ 
https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028735#comment-13028735
 ] 

Pedro Santos commented on WICKET-3655:
--------------------------------------

The consistency can be improved by assembling the component and IHeaderResponse 
in an agrregation type like IResource.Attributes do to assemble the request and 
response.
Pass an object instance to itself as method parameter looks weird.

> Component should use the new renderHead(Component, IHeaderResponse) instead 
> of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3655
>                 URL: https://issues.apache.org/jira/browse/WICKET-3655
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Attila Király
>            Priority: Trivial
>         Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should 
> probably call the IHeaderContributor method instead of the delegated custom 
> method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to