[ 
https://issues.apache.org/jira/browse/WICKET-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029604#comment-13029604
 ] 

Bertrand Guay-Paquet commented on WICKET-3608:
----------------------------------------------

The modifications made to XmlTag.java produce a flood of warnings for 
components with setOutputMarkupId(true).

The warning is :
WARN  - TagAttributes              - WARNING: Please use 
component.setMarkupId(String) to change the tag's 'id' attribute.

TagAttribute.checkIdAttribure(String key) does the following:
private void checkIdAttribute(String key)
{
    if ((key != null) && (key.equalsIgnoreCase("id")))
    {
        log.warn("WARNING: Please use component.setMarkupId(String) to change 
the tag's 'id' attribute.");
    }
}

Tracing a little bit, the warnings originate from the statements :
if (getFlag(FLAG_OUTPUT_MARKUP_ID))
{
    tag.put(MARKUP_ID_ATTR_NAME, getMarkupId());
}
in
Component.onComponentTag(ComponentTag tag)

As far as I can see, this happens because XmlTag uses TagAttributes instead of 
ValueMap in  void copyPropertiesTo(final XmlTag dest)

> input button escapes escaped value
> ----------------------------------
>
>                 Key: WICKET-3608
>                 URL: https://issues.apache.org/jira/browse/WICKET-3608
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Sven Meier
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC4
>
>         Attachments: WICKET-3608-martinsfix-test.patch, 
> WICKET-3608-test.patch, WICKET-3608-unescaping-at-TagAttribute.patch, 
> WICKET-3608.patch, double_escaped_test.diff
>
>
> An input button with a value attribute containing escaped characters (>) 
> is double escaped when rendered. Worked in 1.4.x.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to