org/ apache/wicket/markup/html/tree/AbstractTree.java treeNodesRemoved loops 
forever
------------------------------------------------------------------------------------

                 Key: WICKET-3710
                 URL: https://issues.apache.org/jira/browse/WICKET-3710
             Project: Wicket
          Issue Type: Improvement
          Components: wicket-core
    Affects Versions: 1.5-RC4
         Environment: all
            Reporter: Richard Emberson
            Priority: Minor


In the new code just added to AbstractTree, what happens if the cursor is NOT a 
TreeNode:

    for (Object selectedNode : selection)
    { 
      Object cursor = selectedNode;
      while (cursor != null)
      {   
        if (removed.contains(cursor))
        { 
          getTreeState().selectNode(selectedNode, false);
        }
        if (cursor instanceof TreeNode)
        {
          cursor = ((TreeNode)cursor).getParent();
        }
      } 
    }   

I will loop forever. Or, if cursor is always a TreeNode (or null), why do the 
instanceof test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to