Replace "<single-character>" with '<single-characte>' when appending
StringBuilder
----------------------------------------------------------------------------------
Key: WICKET-3712
URL: https://issues.apache.org/jira/browse/WICKET-3712
Project: Wicket
Issue Type: Improvement
Components: wicket-core
Affects Versions: 1.5-RC4
Environment: all
Reporter: Richard Emberson
Priority: Trivial
I noted that someone changed a couple of places where this occurs in the RC3 to
RC4 upgrade;
changing '[" to '[', etc. Well, if someone is energetic, there are some 500
places in the
wicket core code where this could be "fixed". Appending a character is
marginally faster than
appending a string with a single character and it is actually more correct -
appending a character
rather than a string. Running the following script:
find . -name '*.java' -type f -exec grep --with-filename '"."' {} \;
one can find all of the lines in the src.
If you want to write a script that fixes all places where this occurs be
careful that you do not
fix any of the javascript or regular expression patterns.
The other wicket modules and test code also have characters being appended as
strings.
A lot of effort for a little benefit.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
