[jira] [Commented] (WICKET-3721) The Url's query parameters are not properly URL encoded

Mon, 16 May 2011 07:03:28 -0700 

    [ 
https://issues.apache.org/jira/browse/WICKET-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034020#comment-13034020
 ] 

Martin Grigorov commented on WICKET-3721:
-----------------------------------------

I added a failing test case for this: 
org.apache.wicket.markup.html.link.BookmarkablePageLinkTest.bug_testCustomParametersWithSpecialCharacters()
 

> The Url's query parameters are not properly URL encoded
> -------------------------------------------------------
>
>                 Key: WICKET-3721
>                 URL: https://issues.apache.org/jira/browse/WICKET-3721
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC4
>            Reporter: Martin Grigorov
>
> If page parameter has a value with special characters like ' then it is 
> rendered as it is in the produced markup and is only XML encoded but never 
> URL encoded.
> This causes broken html for example in the case when a Link is attached to a 
> non- a|area|link tag:
> <html><body><span wicket:id="link" onclick="var win = 
> this.ownerDocument.defaultView || this.ownerDocument.parentWindow; if (win == 
> window) { 
> window.location.href=&#039;bookmarkable/org.apache.wicket.MockPageWithLink?urlEscapeNeeded=someone&#039;s+ba+parameter&#039;;
>  } ;return false"></span></body></html>
> Notice that &#039; after 'someone' closes the location.href string too early 
> and breaks the app.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to