[ 
https://issues.apache.org/jira/browse/WICKET-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051479#comment-13051479
 ] 

Juergen Donnerstag commented on WICKET-3812:
--------------------------------------------

Disabled the copy-attributes feature and made it optional. See 
TagUtils.copyAttributes() and AssociatedMarkupSourcingStrategy.onComponentTag()

> xmlns:wicket="http://wicket.apache.org"; rendered for each panel
> ---------------------------------------------------------------
>
>                 Key: WICKET-3812
>                 URL: https://issues.apache.org/jira/browse/WICKET-3812
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5
>            Reporter: Martijn Dashorst
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-RC6
>
>
> The markup for rendered pages including a Panel now suddenly renders 
> xmlns:wicket="http://wicket.apache.org";, making the markup invalid. See below 
> for a piece of our markup, and further below for a test that exhibits this 
> behavior.
> <div id="modalWindowContainer40"><!-- MARKUP FOR 
> nl.topicus.cobra.web.components.modal.ModalWindowContainer BEGIN -->
> <div id="id141" xmlns:wicket="http://wicket.apache.org"; 
> style="display:none"><!-- MARKUP FOR 
> nl.topicus.cobra.web.components.modal.CobraModalWindow$InternalModalWindow 
> BEGIN -->
>  
> <!-- MARKUP FOR 
> nl.topicus.cobra.web.components.modal.CobraModalWindow$InternalModalWindow 
> END --></div><div id="id242" xmlns:wicket="http://wicket.apache.org"; 
> style="display:none"><!-- MARKUP FOR 
> nl.topicus.cobra.web.components.modal.CobraModalWindow$InternalModalWindow 
> BEGIN -->
>  
> <!-- MARKUP FOR 
> nl.topicus.cobra.web.components.modal.CobraModalWindow$InternalModalWindow 
> END --></div>
> <!-- MARKUP FOR nl.topicus.cobra.web.components.modal.ModalWindowContainer 
> END --></div>
> </div>
>       /**
>        * Tests whether rendering a component, it doesn't show the 
> xmlns:wicket namespace.
>        */
>       @Test
>       public void renderingEmptyPanelDoesntShowWicketXmlns()
>       {
>               WicketTester tester = new WicketTester();
>               tester.startPanel(EmptyPanel.class);
>               assertFalse("Should not contain xmlns:wicket",
>                       
> tester.getLastResponseAsString().contains("xmlns:wicket"));
>       }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to