Author: mgrigorov
Date: Mon Jun 20 12:00:18 2011
New Revision: 1137602
URL: http://svn.apache.org/viewvc?rev=1137602&view=rev
Log:
Minor performance improvement.
Strings.replaceAll() doesn't use RegEx.
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/info/ComponentInfo.java
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/info/ComponentInfo.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/info/ComponentInfo.java?rev=1137602&r1=1137601&r2=1137602&view=diff
==============================================================================
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/info/ComponentInfo.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/info/ComponentInfo.java
Mon Jun 20 12:00:18 2011
@@ -32,19 +32,20 @@ import org.apache.wicket.util.string.Str
public class ComponentInfo
{
private static final char BEHAVIOR_INDEX_SEPARATOR = '.';
- private static final char SEPARATOR = '-';
+ private static final String SEPARATOR = "-";
+ private static final String COMPONENT_SEPARATOR = ":";
private static final String TMP_PLACEHOLDER =
"[[[[[[[WICKET[[TMP]]DASH]]" + Math.random() +
"]]]]";
- private static String encodeComponentPath(String path)
+ private static String encodeComponentPath(CharSequence path)
{
if (path != null)
{
- path = path.replace("" + SEPARATOR, TMP_PLACEHOLDER);
- path = path.replace(':', SEPARATOR);
- path = path.replace(TMP_PLACEHOLDER, "" + SEPARATOR +
SEPARATOR);
- return path;
+ path = Strings.replaceAll(path, SEPARATOR,
TMP_PLACEHOLDER);
+ path = Strings.replaceAll(path, COMPONENT_SEPARATOR,
SEPARATOR);
+ path = Strings.replaceAll(path, TMP_PLACEHOLDER,
SEPARATOR + SEPARATOR);
+ return path.toString();
}
else
{
@@ -52,14 +53,14 @@ public class ComponentInfo
}
}
- private static String decodeComponentPath(String path)
+ private static String decodeComponentPath(CharSequence path)
{
if (path != null)
{
- path = path.replace("" + SEPARATOR + SEPARATOR,
TMP_PLACEHOLDER);
- path = path.replace(SEPARATOR, ':');
- path = path.replace(TMP_PLACEHOLDER, "" + SEPARATOR);
- return path;
+ path = Strings.replaceAll(path, SEPARATOR + SEPARATOR,
TMP_PLACEHOLDER).toString();
+ path = Strings.replaceAll(path, SEPARATOR,
COMPONENT_SEPARATOR);
+ path = Strings.replaceAll(path, TMP_PLACEHOLDER,
SEPARATOR).toString();
+ return path.toString();
}
else
{
