[ 
https://issues.apache.org/jira/browse/WICKET-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052858#comment-13052858
 ] 

Juergen Donnerstag commented on WICKET-3823:
--------------------------------------------

Though this is true, I'm only -0 to change it. We code properly reflects the 
sequence of checks and makes it explicit. The additional check does in no way 
harm performance or quality. More importantly, it'll continue working, even if 
one by purpose or accident removes the final from getStyle sometime in the 
future.

> Unnecessary call to component.getStyle() inside Localizer
> ---------------------------------------------------------
>
>                 Key: WICKET-3823
>                 URL: https://issues.apache.org/jira/browse/WICKET-3823
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Bruno Borges
>            Priority: Minor
>         Attachments: Localizer.patch
>
>
> Localizer calls component.getStyle() before calling Session.get().getStyle(), 
> which seems unecessary since the implementation of component.getStyle() does 
> exactly that, and it's a final method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to