svn commit: r1138368 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java

[mgrigorov]

Author: mgrigorov
Date: Wed Jun 22 09:54:50 2011
New Revision: 1138368

URL: http://svn.apache.org/viewvc?rev=1138368&view=rev
Log:
Minor cleanup.

- remove unused declaration of inner interface
- move initialization of all member fields in the constructor for consistency 
and to be easier to follow in debugger


Modified:
    
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java?rev=1138368&r1=1138367&r2=1138368&view=diff
==============================================================================
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
 (original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
 Wed Jun 22 09:54:50 2011
@@ -67,12 +67,7 @@ public class RequestCycle implements IRe
 {
        private static final Logger log = 
LoggerFactory.getLogger(RequestCycle.class);
 
-       private boolean cleanupFeedbackMessagesOnDetach = true;
-
-       private interface IExecutor<T>
-       {
-               void execute(T object);
-       }
+       private boolean cleanupFeedbackMessagesOnDetach;
 
        /**
         * Returns request cycle associated with current thread.
@@ -102,7 +97,7 @@ public class RequestCycle implements IRe
 
        private final IExceptionMapper exceptionMapper;
 
-       private final RequestCycleListenerCollection listeners = new 
RequestCycleListenerCollection();
+       private final RequestCycleListenerCollection listeners;
 
        private UrlRenderer urlRenderer;
 
@@ -110,9 +105,9 @@ public class RequestCycle implements IRe
        private MetaDataEntry<?>[] metaData;
 
        /** the time that this request cycle object was created. */
-       private final long startTime = System.currentTimeMillis();
+       private final long startTime;
 
-       private RequestHandlerStack requestHandlerExecutor;
+       private final RequestHandlerStack requestHandlerExecutor;
 
        private Response activeResponse;
 
@@ -129,6 +124,9 @@ public class RequestCycle implements IRe
                Args.notNull(context.getRequestMapper(), 
"context.requestMapper");
                Args.notNull(context.getExceptionMapper(), 
"context.exceptionMapper");
 
+               cleanupFeedbackMessagesOnDetach = true;
+               listeners = new RequestCycleListenerCollection();
+               startTime = System.currentTimeMillis();
                requestHandlerExecutor = new HandlerExecutor();
                activeResponse = context.getResponse();
                request = context.getRequest();