[ 
https://issues.apache.org/jira/browse/WICKET-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053871#comment-13053871
 ] 

Martin Grigorov commented on WICKET-3827:
-----------------------------------------

--- wicket-core/src/main/java/org/apache/wicket/Component.java  (revision 
1138875)
+++ wicket-core/src/main/java/org/apache/wicket/Component.java  (working copy)
@@ -2812,7 +2812,6 @@
 
                generatedMarkupId = comp.generatedMarkupId;
                setMetaData(MARKUP_ID_KEY, comp.getMetaData(MARKUP_ID_KEY));
-               setOutputMarkupId(comp.getOutputMarkupId());
        }

solve it.
All tests pass.
I think it is safe.

> Component loses state after replace another one
> -----------------------------------------------
>
>                 Key: WICKET-3827
>                 URL: https://issues.apache.org/jira/browse/WICKET-3827
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC4
>            Reporter: Pedro Santos
>         Attachments: WICKET-3827-markup-id.zip
>
>
> After WICKET-3197 we set the replacement component 'output markup id' flag to 
> be the same as the replaced component [1]. IMO we can't change the component 
> state set by users in benefit of the component being replaced as it can lead 
> to unexpected behaviors like AJAX links or buttons not working. I'm sending a 
> quickstart to exemplify.
> 1- Component#setMarkupId(Component comp)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to