[ 
https://issues.apache.org/jira/browse/WICKET-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053985#comment-13053985
 ] 

Igor Vaynberg commented on WICKET-3832:
---------------------------------------

request handlers are not that opaque. they implement interfaces that expose 
their underbelly. eg: IPageRequestHandler, IComponentRequestHandler.

in the name of better logging why dont we create a 
IIntrospectableRequestHandler { Map<String,Object> introspect(); }

the logger can then check if a request handler implements this and get the 
key/value pairs (or some other format) of details and log them. if the handler 
does not implement this interface the logger can show a warning.

what would be interesting if perhaps we allowed the return data to be a tree of 
key/value pairs - like json. and then collect and render it in the debugbar.

> RequestLogger doesn't log incoming event and outgoing page
> ----------------------------------------------------------
>
>                 Key: WICKET-3832
>                 URL: https://issues.apache.org/jira/browse/WICKET-3832
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC4
>            Reporter: Martijn Dashorst
>
> The requestlogger currently doesn't log the incoming request and the outgoing 
> page, which it did in 1.4.x (and earlier). This is due to
> getRequestLogger().logEventTarget(handler);
> getRequestLogger().logResponseTarget(handler);
> not being called. This results in log entries like:
> [2011-06-22 11:43:20,836] [TP-Processor6] RequestLogger | 
> time=12,event=null,response=null,sessioninfo=...
> which isn't saying much, and making every presentation I gave on the 
> RequestLogger, and chapter 14 from WiA look foolish :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to