[
https://issues.apache.org/jira/browse/WICKET-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054049#comment-13054049
]
Pedro Santos edited comment on WICKET-3819 at 6/23/11 7:28 PM:
---------------------------------------------------------------
Good point, this logic is belongs to WebPage, not to Page.
About changes in AjaxRequestTarget see
https://fisheye6.atlassian.com/browse/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?r=1138191#to593
the patch is just removing:
- boolean frozen = page.setFreezePageId(true);
- try
(...)
- finally
- page.setFreezePageId(frozen);
everything else is the new formating.
was (Author: pedrosans):
Good point, this logic is belongs to WebPage, not to Page.
About changes in AjaxRequestTarget see
https://fisheye6.atlassian.com/browse/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?r=1138191#to593
the patch is just removing:
- boolean frozen = page.setFreezePageId(true);
- try
(...)
- finally
- page.setFreezePageId(frozen);
everything else if the new formating.
> Ensure page id don't get increased inside an AJAX request cycle
> ---------------------------------------------------------------
>
> Key: WICKET-3819
> URL: https://issues.apache.org/jira/browse/WICKET-3819
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.5-RC5
> Reporter: Pedro Santos
> Attachments: WICKET-3819.patch
>
>
> The subject started being discussed at WICKET-3751 despite not being related
> to. Currently the page id gets frozen if AjaxRequestTarget or
> RequestListenerInterface identify the page as the target of the AJAX request.
> As user can be using more than 1 page at the same time, opening popups, modal
> windows, frames, etc, would make sense move this spread test and frozen logic
> to a central place: the page itself. The benefit is to make sure that no page
> id will be changed inside an AJAX request compromising every already rendered
> URL in browser, and the removal of duplicated code in the framework to a
> central place.
> We can even consider to simple remove the freeze page id flag from page and
> have less complexity in the framework, but I don't know the impact an would
> be more inclined to simple remove duplicated code and centralize it in Page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
