[
https://issues.apache.org/jira/browse/WICKET-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martijn Dashorst resolved WICKET-3839.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC6
Solved as part of WICKET-3832
> RequestLogger issues
> --------------------
>
> Key: WICKET-3839
> URL: https://issues.apache.org/jira/browse/WICKET-3839
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-RC5.1
> Environment: all
> Reporter: Richard Emberson
> Assignee: Martijn Dashorst
> Priority: Trivial
> Fix For: 1.5-RC6
>
>
> Method objectRemoved looks for WebSssion but
> methods objectCreated and objectUpdated look for
> Session.
> In the objectCreated, objectUpdated and objectRemoved
> methods for Sessions, why not log the Session's id
> just as he page's id is logged? It will make it easier
> of line-up Session events with a particular session.
> LinkedList override method add only removes one
> entry, which assumes that the RequestsWindowSize
> (Application.get.getRequestLoggerSettings.getRequestsWindowSize)
> can not be changed (shrunk) at runtime (as the
> application is running).
> In method requestTime, when will the final else-statement
> be executed:
> SessionData sd = liveSessions.get(sessionId);
> if (sd == null)
> {
> // passivated session or logger only started after it.
> sessionCreated(sessionId);
> sd = liveSessions.get(sessionId);
> }
> // NOTE: at this point sd != null
> if (sd != null)
> {
> sd.setSessionInfo(sessionInfo);
> sd.setSessionSize(sizeInBytes);
> sd.addTimeTaken(timeTaken);
> log(rd, sd);
> }
> else
> {
> log(rd, null);
> }
> As an aside, you might have the method, sessionCreated return
> the SessionData it just created so in the above code one would have:
> if (sd == null)
> {
> // passivated session or logger only started after it.
> sd = sessionCreated(sessionId);
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
