[
https://issues.apache.org/jira/browse/WICKET-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov updated WICKET-3845:
------------------------------------
Attachment: wicket-3845.patch
I've been thinking about renaming current setResponseHeaders() to
internalSetResponseHeaders() and adding new setResponseHeaders() which can be
overridden by the user.
See this patch.
The only thing that I don't like is that the method will not be invoked for
non-web response. I don't see non-web usage of AbstractResource but there is
WebResponse specialization for Response class.
I'm trying to say that AbstractResponse is too webby even now with all the
headers it already handles.
> There is not a good way to use custom response headers with AbstractResource
> ----------------------------------------------------------------------------
>
> Key: WICKET-3845
> URL: https://issues.apache.org/jira/browse/WICKET-3845
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Adriano dos Santos Fernandes
> Fix For: 1.5-RC6
>
> Attachments: custom-headers.patch, wicket-3845.patch
>
>
> I'm converting an application to Wicket 1.5 and I see some problems with
> resources.
> There is a case I need to add headers (not present in ResourceResponse
> properties) and it looks ugly.
> This is what I need to do:
> @Override
> protected void configureCache(ResourceResponse data, Attributes
> attributes)
> {
> super.configureCache(data, attributes);
> ((WebResponse) attributes.getResponse()).setHeader("Accept-Ranges",
> "bytes");
> }
> It's a hack to use configureCache here, but this can't be added to
> setResponseHeaders, which seams a better apparent method name for it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
