[ 
https://issues.apache.org/jira/browse/WICKET-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sven Meier resolved WICKET-3784.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC6

Unified ListMultipleChoice, CheckGroup and MultiFileUploadField.

> ListMultipleChoice should allow its model to return a different collection on 
> each access
> -----------------------------------------------------------------------------------------
>
>                 Key: WICKET-3784
>                 URL: https://issues.apache.org/jira/browse/WICKET-3784
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.17
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>              Labels: collections, model
>             Fix For: 1.5-RC6
>
>         Attachments: ListMultipleChoice.diff
>
>
> With revision 646020 an unnecessary restriction was introduced to 
> ListMultipleChoice, as the model is no longer allowed to return different 
> collections on each invocation of #getObject().
> Note that this change is in conflict with the javadoc of #updateModel() which 
> explicitely allows such usage:
>       /**
>        * If the model object exists, it is assumed to be a Collection, and it 
> is modified in-place.
>        * Then {@link Model#setObject(Object)} is called with the same 
> instance: it allows the Model to
>        * be notified of changes even when {@link Model#getObject()} returns a 
> different
>        * {@link Collection} at every invocation.
>        */
> Please remove the check for identity of the model object, see attached patch.
> Thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to