[
https://issues.apache.org/jira/browse/WICKET-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065845#comment-13065845
]
Carl-Eric Menzel commented on WICKET-3903:
------------------------------------------
Those improvements look fine to me.
> Split AutoLabelResolver into wicket:for and wicket:label
> --------------------------------------------------------
>
> Key: WICKET-3903
> URL: https://issues.apache.org/jira/browse/WICKET-3903
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.4.18, 1.5-RC6
> Reporter: Carl-Eric Menzel
> Assignee: Igor Vaynberg
> Attachments: 0001-split-autolabelresolver.patch, WICKET-3903.diff
>
>
> AutoLabelResolver is combining two different things - managing the "for"
> attribute in <label>, and managing FormComponent#getLabel.
> After an IRC conversation with martin-g and ivaynberg, I propose splitting
> this behavior into two parts, as done in the upcoming patch. Use wicket:for
> as before, use <wicket:label> to output or pick up the label string. See
> AutoFormComponentLabelResolver for details.
> AutoLabelResolver also did not play nice with Enclosure - it would confuse
> Enclosure and make it throw ArrayIndexOutOfBoundExceptions. That could be
> cured by having AutoLabelTagResolver do setAutoComponentTag=true, but that
> again would break AutoLabelResolver's <span> magic. By splitting it up like
> this, that issue is avoided, and wicket:for, wicket:label and Enclosure play
> nicely together.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
