[ 
https://issues.apache.org/jira/browse/WICKET-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067577#comment-13067577
 ] 

Martin Grigorov commented on WICKET-3910:
-----------------------------------------

With this fix AsynchronousDataStore looks like its previous impl.
The previous impl was stable and it works even with your improvement in the 
test, so I'll revert to the previous impl.

> o.a.w.pageStore.AsynchronousDataStore#getData() returns null if the 
> StoreEntryRunnable is currently running
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3910
>                 URL: https://issues.apache.org/jira/browse/WICKET-3910
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5.1
>         Environment: Hostspot 1.6.0_26, 1.5.0_22
>            Reporter: Attila Király
>         Attachments: fix-WICKET-3910.patch, modify-test-WICKET-3910.patch
>
>
> I am running "mvn clean package" on the command line and based on the jdk I 
> get different results (reproducable).
> With jdk6 the test fails and the following is logged:
> ERROR - DiskDataStoreTest          - data[] should never be null
> ERROR - DiskDataStoreTest          - Detected error number: 1
> ERROR - DiskDataStoreTest          - data[] should never be null
> ERROR - DiskDataStoreTest          - Detected error number: 2
> Exception in thread "Thread-22" java.lang.NullPointerException
>       at 
> org.apache.wicket.page.persistent.disk.DiskDataStoreTest$Read1Runnable.run(DiskDataStoreTest.java:231)
>       at java.lang.Thread.run(Thread.java:662)
> Exception in thread "Thread-42" java.lang.NullPointerException
>       at 
> org.apache.wicket.page.persistent.disk.DiskDataStoreTest$Read2Runnable.run(DiskDataStoreTest.java:264)
>       at java.lang.Thread.run(Thread.java:662)
> With jdk5 everything goes fine and above message is not logged.
> The datastore in the test is returning null in the Read1Runnable and 
> Read2Runnable which is causing the NPE.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to