[ 
https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067789#comment-13067789
 ] 

Martin Grigorov commented on WICKET-3884:
-----------------------------------------

I think special values VA_ADD and VA_REMOVE should be deprecated.
If AttributeModifier should be able to remove an attribute then explicit 
#remove(String) method should be added.

> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
>                 Key: WICKET-3884
>                 URL: https://issues.apache.org/jira/browse/WICKET-3884
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5.1
>            Reporter: Robert McGuinness
>            Assignee: Martijn Dashorst
>            Priority: Trivial
>              Labels: attributes
>         Attachments: attr-modifier-by-identity.patch, test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model 
> renders <span class="">Test</span>.  If previous and new attribute are both 
> null, the component should render cleanly like <span>Test</span>.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to