[jira] [Commented] (WICKET-3886) Option for providing caption to DataTable

[Adriano dos Santos Fernandes (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WICKET-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068352#comment-13068352
 ] 

Adriano dos Santos Fernandes commented on WICKET-3886:
------------------------------------------------------

This patch fixes the problem.


diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
index 9c9861c..15f9d7f 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java
@@ -33,6 +33,7 @@ import org.apache.wicket.markup.repeater.RefreshingView;
 import org.apache.wicket.markup.repeater.RepeatingView;
 import org.apache.wicket.markup.repeater.data.IDataProvider;
 import org.apache.wicket.model.IModel;
+import org.apache.wicket.model.Model;
 import org.apache.wicket.util.string.Strings;
 import org.apache.wicket.util.visit.IVisit;
 import org.apache.wicket.util.visit.IVisitor;
@@ -193,7 +194,7 @@ public class DataTable<T> extends Panel implements 
IPageableItems
         */
        protected IModel<String> getCaptionModel()
        {
-               return null;
+               return Model.of("");
        }
 
        /**


> Option for providing caption to DataTable
> -----------------------------------------
>
>                 Key: WICKET-3886
>                 URL: https://issues.apache.org/jira/browse/WICKET-3886
>             Project: Wicket
>          Issue Type: New Feature
>    Affects Versions: 1.5-RC5.1
>            Reporter: Don Ngo
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-RC6
>
>
> Please consider adding an option for providing the value for the caption tag 
> in the DataTable class.  Doing so will allow us to have data table like below:
> <table>
> <caption>Some caption<caption>
> <thead>
> ...
> </thead>
> <tfooter>
> ...
> </tfooter>
> <tbody>
> ...
> </tbody>
> </table>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira