[
https://issues.apache.org/jira/browse/WICKET-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov resolved WICKET-3919.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC6
With r1156643 I committed the patch provided by Martijn Dashorst with minor
fixes and without JSON based request logger.
The updated JSON based logger is attached to the ticket and can be used by any
user application. It wont be included in the distribution until we decide what
will be the architecture.
> RequestLogger generates log entries that are not parsable
> ---------------------------------------------------------
>
> Key: WICKET-3919
> URL: https://issues.apache.org/jira/browse/WICKET-3919
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.5-RC6
>
> Attachments: JsonAndImprovedRequestLogger.txt,
> JsonRequestLogger.java, RequestLoggerTest.java
>
>
> The current (default) request logger generates logs that are not parsable by
> automated tools. The identifiers and values give many collisions with
> keywords, making it impossible to create an efficient ANTLR parser/lexer for
> it.
> A couple of observations:
> - the log is not parsable due to inconsistent logging of log parts. For
> example [ResourceStreamRequestTarget[[]] generates an unbalanced number of
> brackets
> - some parts are joined by ',' and others are joined by ', ' (notice the
> extra whitespace)
> - it is not possible to retrieve parts of the logs because keywords,
> identifiers and values share the same namespace. A page parameter with name
> 'event' would choke a LL(x) parser since the lexer will render a keyword
> instead of a value
> Possible solutions:
> - fix the current format to become consistent and parsable, by surrounding
> identifiers and values with single quotes and escaping single quotes inside
> the identifiers and values, and fixing other issues
> - render JSON instead of the current format (in my opinion best done in a
> separate JSonRequestLogger)
> - ???
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
