[
https://issues.apache.org/jira/browse/WICKET-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088697#comment-13088697
]
Sven Meier commented on WICKET-3978:
------------------------------------
Looks nice. Why is PAGE_TO_BOOKMARKABLE_CACHE still static?
> Delegate the Page#isBookmarkable() to the IPageFactory implementation
> ---------------------------------------------------------------------
>
> Key: WICKET-3978
> URL: https://issues.apache.org/jira/browse/WICKET-3978
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-RC5.1
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-3978.patch
>
>
> Currently org.apache.wicket.Page.isBookmarkable() checks whether the page is
> bookmarkable by checking whether it have either default constructor or a
> constructor with one parameter of type PageParameters.class.
> I think this logic should be delegated to the configured
> org.apache.wicket.IPageFactory because
> org.apache.wicket.session.DefaultPageFactory works with these two
> constructors but custom IPageFactory can work with more/less/other
> constructors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
