svn commit: r1161477 - /wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java

[mgrigorov]

Author: mgrigorov
Date: Thu Aug 25 10:11:53 2011
New Revision: 1161477

URL: http://svn.apache.org/viewvc?rev=1161477&view=rev
Log:
WICKET-3934 Provide AttributeModifier#remove(String)

Fix the test for adding attribute value logical equal (Object#equals()) to 
AttributeModifier.VALUELESS_ATTRIBUTE_REMOVE but not identity equal.


Modified:
    
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java

Modified: 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java?rev=1161477&r1=1161476&r2=1161477&view=diff
==============================================================================
--- 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java
 (original)
+++ 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/AttributeModifierTest.java
 Thu Aug 25 10:11:53 2011
@@ -291,6 +291,8 @@ public class AttributeModifierTest exten
        }
 
        /**
+        * Tests {@link AttributeModifier#remove(String)}
+        * 
         * https://issues.apache.org/jira/browse/WICKET-3934
         */
        @Test
@@ -306,21 +308,22 @@ public class AttributeModifierTest exten
        }
 
        /**
-        * Add an attribute with name equal to the special
-        * {@link AttributeModifier#VALUELESS_ATTRIBUTE_REMOVE}
+        * Add an attribute with name equal (Object#equals()) to the special
+        * {@link AttributeModifier#VALUELESS_ATTRIBUTE_REMOVE} but not 
identity equal
         * 
         * https://issues.apache.org/jira/browse/WICKET-3934
         */
        @Test
        public void appendSpecialAttribute()
        {
-               AttributeModifier appender = 
AttributeModifier.append("VA_REMOVE", "newValue");
+               String attrName = "attrName";
+               AttributeModifier appender = AttributeModifier.append(attrName, 
"VA_REMOVE");
                XmlTag xmlTag = new XmlTag();
                ComponentTag tag = new ComponentTag(xmlTag);
                Map<String, Object> attributes = tag.getAttributes();
-               attributes.put("VA_REMOVE", "oldValue");
+               attributes.put(attrName, "VA_REMOVE");
                appender.replaceAttributeValue(null, tag);
                assertFalse(attributes.isEmpty());
-               assertEquals("oldValue newValue", attributes.get("VA_REMOVE"));
+               assertEquals("VA_REMOVE VA_REMOVE", attributes.get(attrName));
        }
 }